Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: fix the id allocator is not monotonic (#3305) #3308

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3305 to release-4.0


What problem does this PR solve?

What is changed and how it works?

This PR tries to make the id monotonic since there are many components that depend on this property. ref: #3303

Check List

Tests

  • Unit test

Related changes

Release note

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick labels Dec 28, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Dec 28, 2020
@ti-srebot
Copy link
Contributor Author

@rleungx you're already a collaborator in bot's repo.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #3308 (bea1a62) into release-4.0 (703471b) will increase coverage by 0.36%.
The diff coverage is 38.46%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3308      +/-   ##
===============================================
+ Coverage        74.77%   75.13%   +0.36%     
===============================================
  Files              209      209              
  Lines            19594    19599       +5     
===============================================
+ Hits             14651    14726      +75     
+ Misses            3617     3540      -77     
- Partials          1326     1333       +7     
Flag Coverage Δ
unittests 75.13% <38.46%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/server.go 72.80% <0.00%> (-0.87%) ⬇️
server/id/id.go 76.19% <50.00%> (+1.19%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/heartbeat_streams.go 65.93% <0.00%> (-6.60%) ⬇️
server/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/config/persist_options.go 87.16% <0.00%> (-0.76%) ⬇️
server/grpc_service.go 59.87% <0.00%> (+0.40%) ⬆️
server/schedule/operator_controller.go 81.71% <0.00%> (+0.58%) ⬆️
server/cluster/coordinator.go 68.18% <0.00%> (+0.80%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703471b...bea1a62. Read the comment docs.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Dec 30, 2020

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bea1a62

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2020
@ti-chi-bot ti-chi-bot merged commit c3874d9 into tikv:release-4.0 Dec 30, 2020
@HunDunDM
Copy link
Member

This PR contains #3310

@rleungx rleungx modified the milestones: v4.0.9, v4.0.10 Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants